Refactor startup order to not grab ports when checkConfig is true #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexanderritola <alexanderritola@users.noreply.github.com>
77a8e2c to
175e9a6
Compare
matthiasr
approved these changes
Jan 22, 2021
matthiasr
added a commit
that referenced
this pull request
Jan 22, 2021
bring entries into the correct order and prepare to release today Signed-off-by: Matthias Rampke <matthias@prometheus.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the logic pertaining to setting up listeners after the exporter is created and the
checkConfig(#263) early exit is evaluated.In a CI setting, where the goal is to validate the config, setting up listeners seems unnecessary and presents opportunities for unrelated build failures.
I tested a number of startup configurations and I don't believe this breaks anything.
@matthiasr