Add metric to track unique metric names the exporter is tracking #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Akins <brian@akins.org>
|
Would it be valuable to break this down by type (gauge/counter/summary/histogram)? |
|
I can add a label per type, fix the decrement, and make it a gauge. I was thinking of a slightly different approach as well. This was a quick PR to gauge interest. |
|
I think this is a useful thing to track! |
matthiasr
approved these changes
Apr 15, 2019
Signed-off-by: Brian Akins <brian@akins.org>
|
@matthiasr done. Sorry, I keep forgetting to do that. |
|
I use an alias so I don't forget 😅 |
matthiasr
pushed a commit
that referenced
this pull request
Apr 16, 2019
Signed-off-by: Matthias Rampke <mr@soundcloud.com>
matthiasr
pushed a commit
that referenced
this pull request
May 15, 2019
* [CHANGE] Do not run as root in the Docker container by default ([#202](#202)) * [FEATURE] Add metric for count of events by action ([#193](#193)) * [FEATURE] Add metric for count of distinct metric names ([#200](#200)) * [FEATURE] Add UNIX socket listener support ([#199](#199)) * [FEATURE] Accept Datadog [distributions](https://docs.datadoghq.com/graphing/metrics/distributions/) ([#211](#211)) * [ENHANCEMENT] Add a health check to the Docker container ([#182](#182)) * [ENHANCEMENT] Allow inconsistent label sets ([#194](#194)) * [ENHANCEMENT] Speed up sanitization of metric names ([#197](#197)) * [ENHANCEMENT] Enable pprof endpoints ([#205](#205)) * [ENHANCEMENT] DogStatsD tag parsing is faster ([#210](#210)) * [ENHANCEMENT] Cache mapped metrics ([#198](#198)) * [BUGFIX] Fix panic if a mapping resulted in an empty name ([#192](#192)) * [BUGFIX] Ensure that there are always default quantiles if using summaries ([#212](#212)) * [BUGFIX] Prevent ingesting conflicting metric types that would make scraping fail ([#213](#213)) With #192, the count of events rejected because of negative counter increments has moved into the `statsd_exporter_events_error_total` metric, instead of being lumped in with the different kinds of successful events. Signed-off-by: Matthias Rampke <mr@soundcloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we track the number of mappings, but not the unique metricNames. This adds a simple counter to track the count of metricName+labelNames. If this number increases significantly, then the application sending metrics may be misbehaving. This does not count unique label values.
I didn't see a way to get this in the current metrics, so please let me know if there is an existing way to get this information.