Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossbuild attempts to compile unsupported openbsd-armv5 #65

Closed
stuartnelson3 opened this issue Apr 21, 2017 · 11 comments
Closed

crossbuild attempts to compile unsupported openbsd-armv5 #65

stuartnelson3 opened this issue Apr 21, 2017 · 11 comments
Labels

Comments

@stuartnelson3
Copy link

Crossbuild for master in alertmanager is failing on openbsd-armv5:

# openbsd-armv5

>> building binaries

 >   alertmanager

 >   amtool

# github.com/prometheus/alertmanager/vendor/golang.org/x/sys/unix

/go/src/github.com/prometheus/alertmanager/vendor/golang.org/x/sys/unix/flock.go:18: undefined: Flock_t

/go/src/github.com/prometheus/alertmanager/vendor/golang.org/x/sys/unix/sockcmsg_unix.go:36: undefined: Cmsghdr

/go/src/github.com/prometheus/alertmanager/vendor/golang.org/x/sys/unix/sockcmsg_unix.go:42: undefined: Cmsghdr

https://circleci.com/gh/prometheus/alertmanager/619

Looking at package x/sys/unix, the files the expected file for these definitions x/sys/unix/ztypes_openbsd_arm.go does not exist.

Checking against the site for supported platforms, they only have armv7:
https://www.openbsd.org/plat.html

Seems like this should be removed from the crossbuild?

@stuartnelson3
Copy link
Author

cf. prometheus/alertmanager#723

@grobie
Copy link
Member

grobie commented Apr 22, 2017

Sounds good to me. I actually don't understand how we translate arm to arm5/arm6/arm7.

@sdurrheimer
Copy link
Contributor

@grobie Nothing special, a hard-coded in the golang-builder / arm image.

@grobie
Copy link
Member

grobie commented Apr 22, 2017

@sdurrheimer So that means we can't easily just disable openbsd support vor ARMv5, but leave Linux support for ARMv5, right? Any suggestion how to handle this?

@sdurrheimer
Copy link
Contributor

Need to rethink a little bit the system. I wasn't aware of such incompatibilities. I didn't play much with ARM.

@grobie
Copy link
Member

grobie commented Apr 22, 2017

Alternatively, maybe we can just disable all ARMv5 builds. @discordianfish Do you know whether ARMv5 is still widely in use?

@discordianfish
Copy link
Member

It is, at least RPI 1+2 are armv5

@sdurrheimer
Copy link
Contributor

Looking at this page
we should only support:

  • linux: v5, v6, v7
  • freebsd: v6, v7
  • openbsd: v7
  • netbsd: v6, v7

Am I right ?

@stuartnelson3
Copy link
Author

That seems correct. As things change we can always update support, too.

@grobie
Copy link
Member

grobie commented Jun 6, 2017

Cool, so we can just replicate that matrix in the golang builder and fix this here?

@sdurrheimer
Copy link
Contributor

I'm working on it, need to update both promu and golang-builder.

sdurrheimer added a commit to prometheus/golang-builder that referenced this issue Jun 6, 2017
sdurrheimer added a commit that referenced this issue Jun 6, 2017
+ providing retro-compatibility with existing .promu.yml files via
aliases
sdurrheimer added a commit that referenced this issue Jun 7, 2017
+ providing retro-compatibility with existing .promu.yml files via
aliases
sdurrheimer added a commit to prometheus/golang-builder that referenced this issue Jun 7, 2017
Fix prometheus/promu#65 by compiling only provided ARM platforms
sdurrheimer added a commit that referenced this issue Jun 7, 2017
Fix #65 by building only ARM compatible platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants