Add label aggregation for innodb buffer metrics #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b386f9e to
644ec80
Compare
|
Ping @grypyrg, is this what you're looking for? |
|
Ping @grypyrg |
| @@ -30,7 +30,10 @@ func TestScrapeInnodbMetrics(t *testing.T) { | |||
| AddRow("buffer_pool_size", "server", "value", "Server buffer pool size (all buffer pools) in bytes", 2). | |||
| AddRow("buffer_page_read_system_page", "buffer_page_io", "counter", "Number of System Pages read", 3). | |||
| AddRow("buffer_page_written_undo_log", "buffer_page_io", "counter", "Number of Undo Log Pages written", 4). | |||
| AddRow("NOPE", "buffer_page_io", "counter", "An invalid buffer_page_io metric", 5) | |||
| AddRow("buffer_pool_pages_dirty", "buffer", "gauge", "Number of Undo Log Pages written", 5). | |||
There was a problem hiding this comment.
Maybe "Number of Undo Log Pages written" needs to be changed in these rows?
|
Apart from the code comment, looks good to me. (sorry for delay in replying) |
Add label aggregation for innodb_metrics buffer subsystem. * Total can be ignored as it is an aggregation of data+misc+free * Dirty pages are not aggregateable, keep as a separate metric.
644ec80 to
7c3e51a
Compare
|
@grypyrg Fixed comment in tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add label aggregation for innodb_metrics buffer subsystem.