Document smtp_hello parameter #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,8 @@ global: | |||
| [ smtp_from: <tmpl_string> ] | |||
| # The default SMTP smarthost used for sending emails. | |||
| [ smtp_smarthost: <string> ] | |||
| # The default hostname to identify to the SMTP server. | |||
There was a problem hiding this comment.
I think we should mention the default behaviour of using localhost here somehow.
038d666 to
805a91c
Compare
| @@ -65,6 +65,9 @@ global: | |||
| [ smtp_from: <tmpl_string> ] | |||
| # The default SMTP smarthost used for sending emails. | |||
| [ smtp_smarthost: <string> ] | |||
| # The default hostname to identify to the SMTP server. If not specified, | |||
There was a problem hiding this comment.
We usually do this as | default = "localhost", and it might be worth making that explicit over in the am code.
472ff32 to
fe258ea
Compare
simonpasquier
commented
Mar 16, 2018
| @@ -301,6 +306,8 @@ to: <tmpl_string> | |||
|
|
|||
| # The HTML body of the email notification. | |||
| [ html: <tmpl_string> | default = '{{ template "email.default.html" . }}' ] | |||
| # The text body of the email notification. | |||
| [ text: <tmpl_string> ] | |||
There was a problem hiding this comment.
This parameter has been added in prometheus/alertmanager#934.
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* op-guide: update monitor format * op-guide: update punctuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of prometheus/alertmanager#892