Clarify inhibition heuristics with equal labels
#1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,6 +196,10 @@ when an alert (source) exists that matches another set of matchers. | |||
| Both target and source alerts must have the same label values | |||
| for the label names in the `equal` list. | |||
|
|
|||
| Prometheus interprets any missing label as a label with an empty value. | |||
There was a problem hiding this comment.
It's not an interpretation, they're the same thing semantically.
| Prometheus interprets any missing label as a label with an empty value. | ||
| Therefore, if all the label names listed in `equal` are missing from both the | ||
| source and target alerts, the inhibition rule will apply. | ||
|
|
||
| __Alerts can inhibit themselves. Avoid writing inhibition rules where |
There was a problem hiding this comment.
Thank you! Removed, was fixed at prometheus/alertmanager#1017.
Signed-off-by: Thomás S. Bregolin <thoms3rd@gmail.com>
675d0ec to
2222d37
Compare
|
Thanks! |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
Point to version specific directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabxc @brian-brazil This clarifies the intended behaviour of inhibitions in regards to
equallabels, as discussed at prometheus/alertmanager#1727 and prometheus/alertmanager#507