alerting: update Slack configuration #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
| ```yaml | ||
| title: <tmpl_string> | ||
| value: <tmpl_string> | ||
| [ short: <boolean> | default = slack_config.short_fields ] |
There was a problem hiding this comment.
slack_config.actions?
There was a problem hiding this comment.
Hmm, I don't get your remark.
There was a problem hiding this comment.
You had this at a different indentation previously
| @@ -449,20 +451,49 @@ Slack notifications are sent via [Slack webhooks](https://api.slack.com/incoming | |||
| channel: <tmpl_string> | |||
|
|
|||
| # API request data as defined by the Slack webhook API. | |||
| [ color: <tmpl_string> | default = '{{ if eq .Status "firing" }}danger{{ else }}good{{ end }}' ] | |||
| [ icon_emoji: <tmpl_string> ] | |||
There was a problem hiding this comment.
At this stage we should probably sort alphabetically
There was a problem hiding this comment.
I think it is better (for now) to keep the parameters that go into the webhook notification separated from the parameters that control the attachment because of the Slack API documentation which keeps them apart.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
@mpalmer @robcomcast please take a look since you've reported on the original issue. |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* Update binary-deployment.md * Add local deployment guide * Add testing guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501.