Read oauth2 secret from file #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
|
I also need to add a check that a user does not pass the client_secret and the client_secret_file |
roidelapluie
commented
Apr 26, 2021
| return nil, fmt.Errorf("unable to read oauth2 client secret file %s: %s", rt.config.ClientSecretFile, err) | ||
| } | ||
| secret = string(data) | ||
| changed = secret != rt.secret |
There was a problem hiding this comment.
todo: add rlock here
|
Todo: strip extra blank chars |
|
Everything so far looks good! |
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
|
Yes thanks!!! |
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
added 2 commits
April 27, 2021 01:00
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @LeviHarrison
I still need to add tests.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu