Update to 2021 edition #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in prometheus#64, this commit update edition key of manifest file into 2021. Before update, I ran 'cargo fix --edition' to check if migration is needed as this guide(https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html#migration) says. There was no change but following message was printed about the upstream dependencies as mentioned in (https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#migration) 'When building the following dependencies, the given features will no longer be used: syn v1.0.95 (as host dependency) removed features: extra-traits, full, visit, visit-mut The following differences only apply when building with dev-dependencies: standback v0.2.17 (as host dependency) removed features: std syn v1.0.95 (as host dependency) removed features: visit' Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
As documented in 2021 edition guide(https://doc.rust-lang.org/edition-guide/rust-2021/IntoIterator-for-arrays.html), array.into_iter() now returns owned value instead of references, This commit changes previous doc comments to utilize new behavior. Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
|
close #64 |
mxinden
reviewed
May 29, 2022
There was a problem hiding this comment.
Thanks!
Just needs:
- Version bump in
Cargo.tomltov0.17.0. - Changelog entry in
CHANGELOG.md. - Edition update to
2021inderive-text-encode/Cargo.toml. - Version bump in
derive-text-encode/Cargo.toml. - Update of
prometheus-client-derive-text-encodein root levelCargo.tomlto new version.
doehyunbaek
added a commit
to doehyunbaek/client_rust
that referenced
this pull request
May 31, 2022
Accordiing to suggestions here(prometheus#65 (review)).
Accordiing to suggestions here(prometheus#65 (review)). Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
|
Applied suggestion here1bca5bc. |
mxinden
approved these changes
Jun 1, 2022
ackintosh
pushed a commit
to ackintosh/client_rust
that referenced
this pull request
Aug 27, 2022
As suggested in prometheus#64, this commit update edition key of manifest file into 2021. As documented in 2021 edition guide(https://doc.rust-lang.org/edition-guide/rust-2021/IntoIterator-for-arrays.html), array.into_iter() now returns owned value instead of references, This commit changes previous doc comments to utilize new behavior. Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used 2021 edition cargo fix tool (cargo fix --edition) and there was no code change in the repo. Though I am pretty confident in Rust team's ability to make good refactoring tools, I went through changes in the edition guide and there seemed to be no problem.
One little thing I'm worried about is the message I got when I ran fix tool, which is also pasted in commit description, which is
would you mind taking a look at this?