Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float histograms #346

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Float histograms #346

merged 1 commit into from
Dec 5, 2018

Conversation

brian-brazil
Copy link
Contributor

Fixes #345

@tivvit
Copy link

tivvit commented Nov 15, 2018

wow cool thanks for the speed!

@tivvit
Copy link

tivvit commented Nov 23, 2018

I think that it looks ok, but I do not know the codebase much and I do not have the rights to merge it. Who would be the best person to merge this @brian-brazil?

@brian-brazil
Copy link
Contributor Author

There's more work to be done here, it looks like we're going the other way on this.

@brian-brazil brian-brazil force-pushed the float-histo branch 2 times, most recently from 7b879e9 to 7327378 Compare November 30, 2018 16:09
@brian-brazil
Copy link
Contributor Author

This is updated now.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-brazil brian-brazil merged commit 9c19f81 into master Dec 5, 2018
@brian-brazil brian-brazil deleted the float-histo branch December 5, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants