Skip to content

Commit

Permalink
Remove bucket option for now. (#1108)
Browse files Browse the repository at this point in the history
Signed-off-by: bwplotka <bwplotka@gmail.com>
  • Loading branch information
bwplotka authored Aug 5, 2022
1 parent 881c608 commit c0a21ca
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions prometheus/collectors/go_collector_latest.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func WithGoCollectorMemStatsMetricsDisabled() func(options *internal.GoCollector
}

// GoRuntimeMetricsRule allow enabling and configuring particular group of runtime/metrics.
// TODO(bwplotka): Consider adding ability to adjust buckets.
type GoRuntimeMetricsRule struct {
// Matcher represents RE2 expression will match the runtime/metrics from https://golang.bg/src/runtime/metrics/description.go
// Use `regexp.MustCompile` or `regexp.Compile` to create this field.
Expand Down
1 change: 0 additions & 1 deletion prometheus/internal/go_collector_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import "regexp"
type GoCollectorRule struct {
Matcher *regexp.Regexp
Deny bool
Buckets interface{}
}

// GoCollectorOptions should not be used be directly by anything, except `collectors` package.
Expand Down

0 comments on commit c0a21ca

Please sign in to comment.