Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when no mesh router is configured #919

Merged
merged 2 commits into from
Jul 22, 2017
Merged

Conversation

juliusv
Copy link
Member

@juliusv juliusv commented Jul 22, 2017

This adds a check for meshListen != "" around the waitFunc code as we
have around the other mesh-related code parts above.

Fixes #914

This adds a check for `meshListen != ""` around the waitFunc code as we
have around the other mesh-related code parts above.

Fixes #914
@stuartnelson3
Copy link
Contributor

Looking into the bindata failure ..

Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to work, just need to figure out what's up with the bindata

@stuartnelson3
Copy link
Contributor

I had to clean and completely remake the project in order to get these autogenerated changes

@stuartnelson3 stuartnelson3 merged commit b78869e into master Jul 22, 2017
@stuartnelson3 stuartnelson3 deleted the fix-nomesh-crash branch July 22, 2017 08:56
iksaif pushed a commit to iksaif/alertmanager that referenced this pull request Sep 15, 2017
* Fix crash when no mesh router is configured

This adds a check for `meshListen != ""` around the waitFunc code as we
have around the other mesh-related code parts above.

Fixes prometheus#914

* Update bindata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants