Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current time to go webhook standard output #909

Merged
merged 1 commit into from
Jul 27, 2017
Merged

Add current time to go webhook standard output #909

merged 1 commit into from
Jul 27, 2017

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jul 16, 2017

This is just a small addition for better debugging of notifications send
by Alertmanager.

@mxinden mxinden requested a review from stuartnelson3 July 16, 2017 18:19
stuartnelson3
stuartnelson3 reviewed Jul 18, 2017
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, is there a reason you don't want to use log.Println? That adds time on its own.

2017/07/18 11:38:25 6
2017/07/18 11:38:25 [foo@bar.com baz@quux.edu]

@mxinden
Add current time to go webhook standard output
8896105 
This is just a small addition for better debugging of notifications send
by Alertmanager.
@mxinden
Copy link
Member Author

mxinden commented Jul 22, 2017

@stuartnelson3 Good catch. Thanks. Adjusted accordingly.

@mxinden mxinden merged commit ed52b4b into prometheus:master Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @stuartnelson3