Add User-Agent for webhook requests #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartnelson3
suggested changes
Jul 10, 2017
| @@ -135,6 +136,8 @@ func BuildReceiverIntegrations(nc *config.Receiver, tmpl *template.Template) []I | |||
|
|
|||
| const contentTypeJSON = "application/json" | |||
|
|
|||
| var userAgentHeader = fmt.Sprintf("Alertmanager/%s", version.Version) | |||
There was a problem hiding this comment.
Could you put this and the preceeding line into a const declaration block?
const (
contentTypeJSON = "application/json"
userAgentHeader = fmt.Sprintf("Alertmanager/%s", version.Version)
)There was a problem hiding this comment.
I tried that but I got this error
# github.com/prometheus/alertmanager/notify
notify/impl.go:139: const initializer fmt.Sprintf("Alertmanager/%s", version.Version) is not a constant
!! command failed: build -o ~/.golang/src/github.com/prometheus/alertmanager/alertmanager -ldflags -X github.com/prometheus/alertmanager/vendor/github.com/prometheus/common/version.Version=0.7.1 -X github.com/prometheus/alertmanager/vendor/github.com/prometheus/common/version.Revision=e60ffbe6fb8c58f45864fccd1c741219402c2617 -X github.com/prometheus/alertmanager/vendor/github.com/prometheus/common/version.Branch=user-agent -X github.com/prometheus/alertmanager/vendor/github.com/prometheus/common/version.BuildUser=<removed> -X github.com/prometheus/alertmanager/vendor/github.com/prometheus/common/version.BuildDate=20170710-23:55:18 -s -a -tags netgo github.com/prometheus/alertmanager/cmd/alertmanager: exit status 2
make: *** [build] Error 1
I'm not familiar with Go, so I'm not sure how to fix that.
There was a problem hiding this comment.
Tried to read up on things, but since const is checked at compile time, but it seems like version.Version is filled in by the linker, it may not be possible to have userAgentHeader as a const (and in the linked PR for Prometheus it's a var there as well)
There was a problem hiding this comment.
Yes, consts in Go can't be calculated unfortunately.
There was a problem hiding this comment.
Oh my mistake, sorry.
stuartnelson3
approved these changes
Jul 11, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://github.com/prometheus/prometheus/pull/2447/files as an example, this adds a user agent for Webhook requests.
This is the first time I've written code in go, so please let me know what I can fix up.
It's likely that the same user agent could be used for the other notifiers but for now I have only added this to the webhook notifier.
@stuartnelson3