Add (optional) names to routes #3820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds (optional) names to routes to fix prometheus#3817. In the case where a user has two routes with the same receiver, matchers and group_by, a name can be used to ensure their groups have unique group keys and avoid using the same nflog. Signed-off-by: George Robinson <george.robinson@grafana.com>
|
It implies that the user knows in advance that 2 routes are going to create identical group keys? It doesn't seem to me a nice user experience. What if Alertmanager adds the route index when it suspects a possible conflict? Would it solve the problem? |
That's what we tried here, but it has unintended side effects. For example, if a new route is added to the beginning of the list of routes then it invalidates the nflogs for all other routes as all the indexes will change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds (optional) names to routes to fix #3817. In the case where a user has two routes with the same receiver, matchers and group by, a name can be used to ensure their groups have unique group keys and avoid using the same nflog.