Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for AuthSecret from file #3087

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for AuthSecret from file #3087

wants to merge 1 commit into from
+148 −2

Conversation

Git-Jiro
Copy link
Contributor

@Git-Jiro Git-Jiro commented Oct 1, 2022

related to: #2498

@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch from 7a8c533 to 90a46c2 Compare October 1, 2022 10:30
@Git-Jiro
Add support for AuthSecret from file
614850c 
Signed-off-by: Martin Schimandl <martin.schimandl@gmail.com>
@Git-Jiro Git-Jiro force-pushed the implement_secrets_from_file branch from 90a46c2 to 614850c Compare October 1, 2022 10:35
@simonpasquier simonpasquier reopened this Oct 3, 2022
@simonpasquier
Copy link
Member

Something's weird with CircleCI reporting Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.... Have you enabled CircleCI on your fork repository?

@Git-Jiro
Copy link
Contributor Author

Git-Jiro commented Oct 3, 2022

I am not aware of doing any Circle CI related stuff on my fork. I just forked and worked on the fix.

@OktarianTB
Copy link
Contributor

Documentation is not up to date with regards to auth_password_file nor auth_secret_file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Git-Jiro @simonpasquier @OktarianTB