-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: add 'Link' button to alerts in list #2880
Conversation
adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com>
Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com>
Visually, the changes look good and seem like a decent improvement to link individual alerts. However, I'm in no capacity to review the FE changes - perhaps @w0rm you can please take a look? Here are a couple of screenshots to confirm what it looks like: Before clicking on "Link"After clicking on "Link" |
thanks for taking a look @gotjosh! Originally, I wanted this to copy the resulting URL to the clipboard, but I wasn't able to figure out how to access the clipboard (I'm not experienced with Elm). This change at least makes it easy to copy the link from the browser's address bar. |
is there any interest in this? If not, I'd close the PR in a week or so |
@ccmtaylor apologies! LGTM |
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
* add 'Link' button adds a button to each alert that allows linking to a single alert. This works by generating a link that filters on _all_ of the alert's label values, similar to the button to create a new silence from an alert. Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> * update asset/assets_vfsdata.go Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Christopher Taylor <chris.taylor@soundcloud.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
adds a button to each alert that allows linking to a single alert.
This works by generating a link that filters on all of the alert's
label values, similar to the button to create a new silence from an
alert.