-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return no error when deleting expired silence #2817
Merged
simonpasquier
merged 14 commits into
prometheus:main
from
rajagopalanand:20211207-expire-silence-idempotency-fix
Feb 22, 2022
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d389091
Changed Silences.expire(id) to not return error for already expired s…
soonping-amzn 342fef5
Added comment explaining idempotency change for Silences.expire()
soonping-amzn 3ddd3e6
Trigger build
soonping-amzn 1e7879f
Trigger build
soonping-amzn 2a7ef46
Fixed typo in comment
soonping-amzn 53a300e
Trigger build
soonping-amzn cc0283c
Trigger build
soonping-amzn e3f9f46
Fixed another typo in comment
soonping-amzn 8e605a4
Promoted comment to function-level
soonping-amzn 4b776b9
Added API v2 test for DeleteSilence, PostSilence
soonping-amzn 5d0d557
Fixed lint errors
soonping-amzn 619b390
Trigger build
soonping-amzn 451452d
Trigger build
soonping-amzn 4c36579
Trigger build
soonping-amzn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for coming in late - I feel that this kind of comment about the semantics of the function is best put as part of the function description.
How do you feel about changing the top-level comment from:
to
and removing the comment on the body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I'll make the change.