-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement opsgenie_api_key_file #2728
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
opsgenie_api_key_file
branch
from
October 1, 2021 11:29
f4c8178
to
42e4c39
Compare
roidelapluie
approved these changes
Oct 18, 2021
Can you rebase the configuration doc? Thanks! |
Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de>
jkroepke
force-pushed
the
opsgenie_api_key_file
branch
from
October 21, 2021 07:15
42e4c39
to
8499630
Compare
@roidelapluie done |
roidelapluie
approved these changes
Oct 21, 2021
Thanks! |
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de>
markoposavec
pushed a commit
to markoposavec/alertmanager
that referenced
this pull request
Nov 4, 2021
Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de> Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
simonpasquier
added a commit
to simonpasquier/alertmanager
that referenced
this pull request
May 4, 2022
The validation should fail if both `api_key` and `api_key_file` are defined. I think there was a typo in the original PR (prometheus#2728) that enforced `api_url` and `api_key_file` not being defined at the same time. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Dec 13, 2022
The validation should fail if both `api_key` and `api_key_file` are defined. I think there was a typo in the original PR (prometheus#2728) that enforced `api_url` and `api_key_file` not being defined at the same time. Signed-off-by: Simon Pasquier <spasquie@redhat.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i'm coming from #2498 (comment)
Due some shared responsbilities in our teams, we would to read a api key from external kubernetes secret (which is mounted through an file)
Most changes taken from #2534
golang isnt my main, I do a lot copy and paste from the slack implementation PR.
Thanks