Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement opsgenie_api_key_file #2728

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

jkroepke
Copy link
Contributor

@jkroepke jkroepke commented Oct 1, 2021

Hi,

i'm coming from #2498 (comment)

Due some shared responsbilities in our teams, we would to read a api key from external kubernetes secret (which is mounted through an file)

Most changes taken from #2534

golang isnt my main, I do a lot copy and paste from the slack implementation PR.

Thanks

@roidelapluie
Copy link
Member

Can you rebase the configuration doc? Thanks!

Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de>
@jkroepke jkroepke force-pushed the opsgenie_api_key_file branch from 42e4c39 to 8499630 Compare October 21, 2021 07:15
@jkroepke
Copy link
Contributor Author

@roidelapluie done

@roidelapluie roidelapluie merged commit 186362c into prometheus:main Oct 21, 2021
@roidelapluie
Copy link
Member

Thanks!

markoposavec pushed a commit to markoposavec/alertmanager that referenced this pull request Nov 4, 2021
Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de>
markoposavec pushed a commit to markoposavec/alertmanager that referenced this pull request Nov 4, 2021
Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de>
Signed-off-by: Marko Posavec <Marko.Posavec@infobip.com>
@jkroepke jkroepke deleted the opsgenie_api_key_file branch December 8, 2021 15:30
simonpasquier added a commit to simonpasquier/alertmanager that referenced this pull request May 4, 2022
The validation should fail if both `api_key` and `api_key_file` are
defined. I think there was a typo in the original PR (prometheus#2728) that
enforced `api_url` and `api_key_file` not being defined at the same
time.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
qinxx108 pushed a commit to qinxx108/alertmanager that referenced this pull request Dec 13, 2022
The validation should fail if both `api_key` and `api_key_file` are
defined. I think there was a typo in the original PR (prometheus#2728) that
enforced `api_url` and `api_key_file` not being defined at the same
time.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants