Allow filtering silences by createdBy author #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
135c96d to
878084f
Compare
|
I was unsure if the argument should be called |
9421d1b to
2ca21ae
Compare
|
Ping @roidelapluie @simonpasquier -- my team would really like to get this issue merged so we can filter silences more effectively. Would one of you mind reviewing this PR? Thanks! 👍 |
roidelapluie
reviewed
Nov 9, 2021
|
sure :) |
9bce4ab to
c6ea2b7
Compare
|
@roidelapluie Thanks for the review and the suggestion; I amended it to the commit. |
roidelapluie
reviewed
Nov 9, 2021
|
Thanks, last suggestions. |
This commit adds a `--created-by` argument to the `amtool silence query` command so that silences can be filtered by the author they were created with in `amtool silence add --author=<name>`. Signed-off-by: nre <nre@ableton.com>
356a095 to
06bc5c2
Compare
roidelapluie
approved these changes
Nov 9, 2021
|
@roidelapluie My CI build failed, but it's not clear to me at all why. I can't retrigger the build, and the |
|
I relaunched it |
|
Thanks! |
|
@roidelapluie Thanks so much for all your help! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--created-byargument to theamtool silence querycommand so that silences can be filtered by the author they were created with inamtool silence add --author=<name>.Fixes #2410, fixes #2476.