VictorOps api-key <SECRET> via file feature #2554
Conversation
|
@beorn7 could you please help out here a bit, not sure why getting so many test case failure. I followed the same structure as that slack_api_url_file commits. Not much familiarity with GO |
|
The first thing to fix is easy: Add the DCO. See https://github.com/prometheus/alertmanager/pull/2554/checks?check_run_id=2426690259 . No Go knowledge required. (o: |
|
You have partially reverted recent changes that added support to read the Slack URL from a file. That's also the reason why the tests and the build fail. Perhaps you have branched of from the master branch before that feature was merged, and then you did not resolve the merge or rebase properly? I'll add a few comments where this happened. |
| if c.Global.SlackAPIURL != nil { | ||
| return fmt.Errorf("at most one of slack_api_url must be configured") | ||
| } |
There was a problem hiding this comment.
This code is about Slack and should not change.
| SMTPAuthIdentity string `yaml:"smtp_auth_identity,omitempty" json:"smtp_auth_identity,omitempty"` | ||
| SMTPRequireTLS bool `yaml:"smtp_require_tls" json:"smtp_require_tls,omitempty"` | ||
| SlackAPIURL *SecretURL `yaml:"slack_api_url,omitempty" json:"slack_api_url,omitempty"` | ||
| SlackAPIURLFile string `yaml:"slack_api_url_file,omitempty" json:"slack_api_url_file,omitempty"` |
There was a problem hiding this comment.
Here you are accidentally removing this line about Slack.
Adding features for inserting VictorOps-api-key secret through file - as suggested in this issue. I haven't tested in local not much familiar with GO, working on that. Any high level review will be really helpful - if I am going in right direction or not. Thanks