Grouping label's expand button with grouping id #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
|
|
w0rm
reviewed
Aug 27, 2019
ui/app/src/Views/AlertList/Views.elm
Outdated
| groups | ||
| (List.indexedMap Tuple.pair groups | ||
| |> List.map | ||
| (\( index, group ) -> |
There was a problem hiding this comment.
There is no need to first do indexedMap to build tuples and then map over tuples. You can call List.indexedMap with \index group ->.
|
A small improvement, everything else looks good! I think that after this change this should also perform better, because the key type of a Set is simpler. Thank you! |
|
Thanks a lot @m-masataka! You need to rebase your PR after #2013 is merged. @stuartnelson3 @mxinden once this gets merged, I suggest that we consider a new release of AlertManager as #1875 is quite annoying and has been reported in different occasions. I can sign up for preparing the new release. |
|
sounds great to me |
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
w0rm
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In alerts screen, Expand/Collapse button cooperated with grouping labels.
So when several groups have the same grouping labels, this button will expand all of them. Related to #1875 .
To fix this issue, I implemented expand button with grouping id. (this id is only used UI)