Recreate silence with previous comment. #1927
Conversation
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
| @@ -114,7 +117,7 @@ editButton silence = | |||
| Expired -> | |||
| a | |||
| [ class "btn btn-outline-info border-0" | |||
| , href (newSilenceFromMatchers silence.matchers) | |||
| , href recreateUrl | |||
There was a problem hiding this comment.
Hey! What do you think about reusing the new silence page and extending it to support passing an optional comment field rather than introducing the whole new route?
i.e. changing this to newSilenceFromMatchersAndComment silence.matchers silence.comment
There was a problem hiding this comment.
@w0rm Thank you for making a comment.
The reason why I introduce whole new route is to deal with possibilities change of SilenceView's field. This means to Avoid implement newSilenceFromMacherAndCommentAndXXXAndXXX..etc , when anyone need to add field in SilenceForm.
If low probability of extending new field in the future, implement newSilenceFromMatchersAndComment is simple and best way.
So, I can't make up my mind which is better.
Which do you think is better?
There was a problem hiding this comment.
Hey! Sorry for taking so long to respond. newSilenceFromMatchersAndComment sounds like a simpler and better option to me.
There was a problem hiding this comment.
Okey.
I’ll change this PR.
Wait a moment please.
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
54b2d6f to
35c9a6a
Compare
|
@m-masataka thank you! |
When recreate silence by expired one, we want to copy over the previous comment and matchers. ( not only matchers)
This PR is related to #1566.
Signed-off-by: m-masataka m.mizukoshi.wakuwaku@gmail.com