Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect regex matchers when recreating silences #1697

Merged
merged 2 commits into from
Jan 9, 2019
Merged

respect regex matchers when recreating silences #1697

merged 2 commits into from
Jan 9, 2019

Conversation

stuartnelson3
Copy link
Contributor

fixes #1695

@stuartnelson3
Respect regexes when recreating silences
a47ddd4 
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
@stuartnelson3
Generate assets
9574a8c 
Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
@stuartnelson3 stuartnelson3 force-pushed the stn/recreate-with-regex branch from e72df3b to 9574a8c Compare January 8, 2019 15:33
@stuartnelson3 stuartnelson3 merged commit dba283e into master Jan 9, 2019
@stuartnelson3 stuartnelson3 deleted the stn/recreate-with-regex branch January 9, 2019 09:33
mxinden pushed a commit to mxinden/alertmanager that referenced this pull request Jan 14, 2019
@stuartnelson3 @mxinden
respect regex matchers when recreating silences (prometheus#1697)
4ea0a1d 
* Respect regexes when recreating silences
* Generate assets

Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
@lachlancooper lachlancooper mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rm w0rm w0rm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recreating a silence unchecks "Regex" checkboxes
2 participants
@stuartnelson3 @w0rm