support for assuming first label is alertname in silence add and query #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you try rebasing on latest master and pushing? it seems to be failing on something that was fixed only yesterday. |
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
stuartnelson3
approved these changes
Jan 7, 2019
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Jan 14, 2019
prometheus#1693) * simplified setting first assumed alertname in cli/silence_query.go * added assumed first label to alertname when adding silences Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1575
This PR adds support for assuming the first label is
alertnamein silence add and query. It was already existing on silence query, did some cleanup.Will create another PR for #1682