config: fix unmarshalling of secret URLs #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
mxinden
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Would you mind adding a comment in the code or in your commit message why you are doing this? E.g. something like
In order to parse a config returned by the Alertmanager API with amtool, `<secret>` needs to be treated specially, as it would not be valid JSON.
Other than that, this looks good to me.
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
Sure, this is done. |
|
Cool, thanks for the quick follow up. Leaving any last comments to @stuartnelson3. |
stuartnelson3
approved these changes
Dec 13, 2018
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Jan 14, 2019
* config: fix unmarshalling of secret URLs * Add comment describing why we need the special case Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1659