Use quoted-printable transfer encoding for the email notifier #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out MIME has a maximum line length of 998 bytes and some SMTP servers will enforce that by inserting a newline after 998 characters, whether that's in the middle of a URL or HTML tag. Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>
59dfa3f to
9513afb
Compare
|
LGTM. I suppose that you've tested it with a real SMTP server? |
Yes I did, sorry for failing to mention that. I've been running an alertmanager with this change for a couple of days now. And I have seen a few alerts with lines longer than 998 characters displayed without corruption, so it works as expected. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
quoted-printabletransfer encoding for the text sent out by the email notifier.Turns out MIME has a maximum line length of 998 bytes (RFC 2822, section 2.1.1) and some SMTP servers will enforce that by inserting a
<CR><LF>after 998 characters, whether that's in the middle of a URL or HTML tag, potentially breaking the email's contents.