Throw error if no auth mechanism is match #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: glefloch <glfloch@gmail.com>
Signed-off-by: glefloch <glfloch@gmail.com>
|
@simonpasquier I have used the |
|
I've restarted the Travis tests as it is probably a flake. In any case, it might be good to add a few unit tests. |
Signed-off-by: glefloch <glfloch@gmail.com>
|
@simonpasquier, I have added unit tests. Could you tell me if this is what you expected? |
|
Thanks for this! 👍 for me. |
mxinden
requested changes
Nov 9, 2018
Signed-off-by: glefloch <glfloch@gmail.com>
mxinden
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to close #1555 by returning an error if no auth mechanism is found.
Signed-off-by: glefloch glfloch@gmail.com