Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the recommended label syntax for maintainer. #1533

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Using the recommended label syntax for maintainer. #1533

merged 1 commit into from
Aug 27, 2018

Conversation

tariq1890
Copy link
Contributor

Fixes #1530

Using the recommended label syntax for maintainer.
6a51098 
Signed-off-by: Tariq Ibrahim <tariq.ibrahim@microsoft.com>
@tariq1890
Copy link
Contributor Author

@simonpasquier Here is the correct PR :)

simonpasquier
simonpasquier approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mxinden mxinden merged commit d03e0ba into prometheus:master Aug 27, 2018
@mxinden
Copy link
Member

mxinden commented Aug 27, 2018

Thanks for the quick fix @tariq1890!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@simonpasquier simonpasquier simonpasquier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariq1890 @mxinden @simonpasquier