Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help tab #1522

Merged
merged 2 commits into from
Aug 15, 2018
Merged

Help tab #1522

merged 2 commits into from
Aug 15, 2018

Conversation

sipian
Copy link
Contributor

@sipian sipian commented Aug 15, 2018

Closes #1192

Since ui/bindata.go is auto-generated while building the elm source code, I have commited this file too.
If it is not necessary, I can git rebase to remove it.

sipian added 2 commits August 16, 2018 01:51
Signed-off-by: Harsh Agarwal <cs15btech11019@iith.ac.in>
Signed-off-by: Harsh Agarwal <cs15btech11019@iith.ac.in>
@sipian
Copy link
Contributor Author

sipian commented Aug 15, 2018

The CircleCI failure is not related to this. The build is passing successfully locally.

Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Re-running circleci

@stuartnelson3 stuartnelson3 merged commit 049663b into prometheus:master Aug 15, 2018
@sipian sipian deleted the help-tab branch August 16, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants