Correctly encode query strings in notifiers #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In moving from a plain string to url.URL, we incorrectly were setting the query string via the path. The `?` signaling the start of the query string would then be escaped when the URL was turned into a string. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
|
👍 my bad...
Agreed. It reinforces the need for unit testing every notifier. Even if the external APIs are out of control, we could still verify that the client still sends the same requests after refactoring. |
|
I'll create an issue, but the first thing that comes to mind is recording the request body and making sure that stays the same |
|
@mxinden I'm technically on vacation .. do you have time to do a release today (or soon)? |
@stuartnelson3 sorry for the delay. I will prepare the release tomorrow. |
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Aug 14, 2018
In moving from a plain string to url.URL, we incorrectly were setting the query string via the path. The `?` signaling the start of the query string would then be escaped when the URL was turned into a string. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Aug 14, 2018
In moving from a plain string to url.URL, we incorrectly were setting the query string via the path. The `?` signaling the start of the query string would then be escaped when the URL was turned into a string. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In moving from a plain string to url.URL, we
incorrectly were setting the query string via the
path. The
?signaling the start of the querystring would then be escaped when the URL was
turned into a string.
@mxinden @simonpasquier I would classify this as extremely important, we should get a release out as soon as this is merged IMO. I'm guessing hipchat, wechat, and opsgenie are all broken?
Fixes #1515