fix: Update PagerDuty API V2 to send full details on resolve #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds compatiblity with PagerDuty's Event rules feature, allowing resolve events to be routed based on attributes Fixes #1440 Signed-off-by: Mike Bryant <m@ocado.com>
|
LGTM. I see that @stuart-warren already +1s. Lets wait a bit for @scarvel8 to weigh in. In case of no response, we can merge it in a few days. |
|
LGTM |
|
I just got notification that PagerDuty have made a change to how their API resolves events:
So it looks like this PR is no longer necessary, but likely wouldn't hurt. |
stuartnelson3
approved these changes
Aug 1, 2018
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Aug 14, 2018
…eus#1483) This adds compatiblity with PagerDuty's Event rules feature, allowing resolve events to be routed based on attributes Fixes prometheus#1440 Signed-off-by: Mike Bryant <m@ocado.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatiblity with PagerDuty's Event rules feature, allowing resolve events to be routed based on attributes
Fixes #1440