Add support for adding alerts using amtool #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Shannon <bshannon@palantir.com>
77f66c7 to
b7b93b6
Compare
cli/alert_add.go
Outdated
| } | ||
| } | ||
|
|
||
| err = alertAPI.Push(context.Background(), client.Alert{ |
There was a problem hiding this comment.
You could just return alertAPI.Push() instead of setting it to err and then returning that.
Signed-off-by: Bob Shannon <bshannon@palantir.com>
stuartnelson3
approved these changes
Jul 13, 2018
There was a problem hiding this comment.
Did a couple manual tests, created and resolved alerts -- looks good. I'll wait a few days to see if @simonpasquier has any comments.
stuartnelson3
added a commit
that referenced
this pull request
Jul 15, 2018
todo: add timeout support to alerts once #1461 is merged. Signed-off-by: Stuart Nelson <stuartnelson3@gmail.com>
|
👍 thanks for doing this! |
gabreal
pushed a commit
to paritytech/alertmanager
that referenced
this pull request
Jul 31, 2018
* Add support for adding alerts using amtool Signed-off-by: Bob Shannon <bshannon@palantir.com> * comment: Simplify return in addAlert Signed-off-by: Bob Shannon <bshannon@palantir.com>
gabreal
pushed a commit
to paritytech/alertmanager
that referenced
this pull request
Jan 28, 2019
* Add support for adding alerts using amtool Signed-off-by: Bob Shannon <bshannon@palantir.com> * comment: Simplify return in addAlert Signed-off-by: Bob Shannon <bshannon@palantir.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1417
cc @stuartnelson3