Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch: don't reset timer if flush is in-progress #1301

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

simonpasquier
Copy link
Member

This helps a bit for #1005 but it isn't a silver bullet.

When the aggregation group receives an alert that is past the initial
group_wait value, it should reset its timer only if the timer has ever
expired. Otherwise it means that the flush is already in-progress.
@stuartnelson3 stuartnelson3 merged commit 4cba491 into prometheus:master Mar 29, 2018
@simonpasquier simonpasquier deleted the minimize-flush-races branch April 5, 2018 14:45
mxinden pushed a commit to mxinden/alertmanager that referenced this pull request May 5, 2018
When the aggregation group receives an alert that is past the initial
group_wait value, it should reset its timer only if the timer has ever
expired. Otherwise it means that the flush is already in-progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants