Hide sensitive Wechat configuration + remove default fields #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5742f5 to
9a57ecb
Compare
config/notifiers.go
Outdated
| }, | ||
| Message: `{{ template "wechat.default.message" . }}`, | ||
| APISecret: `{{ template "wechat.default.api_secret" . }}`, | ||
| ToUser: `{{ template "wechat.default.to_user" . }}`, |
There was a problem hiding this comment.
Why aren't these templated? We do for other notifiers.
There was a problem hiding this comment.
I must admit I have no clue. @songjiayang any insight?
There was a problem hiding this comment.
Hi, guys, I don't known the benefit of templated this fields, I support to delete it like @simonpasquier pr.
There was a problem hiding this comment.
I say we leave it in and just update the wechat secrets to the Secret type for this PR.
There was a problem hiding this comment.
Ack @stuartnelson3. I've rebased the PR to remove the commit on the templated fields.
004ab84 to
79d1e5c
Compare
stuartnelson3
approved these changes
Mar 2, 2018
|
@stuartnelson3 sorry about didn't solve the issues theses days because of some individual things. |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Apr 2, 2019
…heus#1253) The cpu frequency information is not always needed and/or available. This change allows the cpu frequency metrics to be enabled/disabled separately from the other cpu metrics, and also prevents a frequency metric failure (such as a parse error) from failing the main cpu collector. Fixes prometheus#1241 Signed-off-by: Paul Gier <pgier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.