Add mesh metrics #1225
Merged
Add mesh metrics #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds 2 new metrics for the mesh: * alertmanager_peer_connection, state of the connection between the Alertmanager instance and a peer. * alertmanager_peer_terminations_total, total number of terminated connection. It also moves the gathering of the alertmanager_peer_position metric outside of the meshWait() function so that the metric is computed accurately even when no alerting group fires.
brian-brazil
reviewed
Feb 5, 2018
cmd/alertmanager/main.go
Outdated
| connDesc: prometheus.NewDesc( | ||
| "alertmanager_peer_connection", | ||
| "State of the connection between the Alertmanager instance and a peer.", | ||
| []string{"peer", "nick"}, |
There was a problem hiding this comment.
Are both of these labels needed?
There was a problem hiding this comment.
My reasoning is that the nickname makes it easier to identify the peer:
alertmanager_peer_connection{instance="prometheus-0",job="alertmanager",nick="prometheus-1",peer="02:42:ac:11:00:03"} 1
alertmanager_peer_connection{instance="prometheus-1",job="alertmanager",nick="prometheus-0",peer="02:42:ac:11:00:02"} 1
But we can't get rid of of peer altogether since nick's uniqueness isn't enforced by the mesh library.
There was a problem hiding this comment.
these are both belonging to the connected AM, I imagine only one is necessary (comment race)
There was a problem hiding this comment.
I would vote for only using peer. If a user wants to make it easier to identify they can set a custom peer-id.
There was a problem hiding this comment.
Fine with me. I'll update the PR accordingly.
stuartnelson3
approved these changes
Feb 6, 2018
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Apr 2, 2019
* Add smartmon.py python port of the smartmon.sh bash script Signed-off-by: Arthur Skowronek <ags@digineo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 2 new metrics for the mesh:
Alertmanager instance and a peer.
connection.
It also moves the gathering of the alertmanager_peer_position metric
outside of the meshWait() function so that the metric is computed
accurately even when no alerting group fires.
Fixes #1219.