Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display connections in the Status page #1164

Merged
merged 1 commit into from
Dec 22, 2017
Merged

Display connections in the Status page #1164

merged 1 commit into from
Dec 22, 2017

Conversation

simonpasquier
Copy link
Member

Relates to #625.

Mesh status with 2 nodes and one being down

image

Same cluster with the 2 nodes up

image

@simonpasquier
Display connections in the Status page
2f43746 
This change shows the status of the local connections in the web UI. It
can be used to troubleshoot mesh issues.
@simonpasquier simonpasquier mentioned this pull request Dec 22, 2017
Closed
@brancz
Copy link
Member

brancz commented Dec 22, 2017

lgtm, @stuartnelson3 should probably glance over the elm parts

@stuartnelson3
Copy link
Contributor

Interesting, have you seen the state leave pending? The alertmanagers are definitely gossiping silences, but the status is never transitioning from pending to established. Interesting.

stuartnelson3
stuartnelson3 approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stuartnelson3 stuartnelson3 merged commit 364979b into prometheus:master Dec 22, 2017
@simonpasquier
Copy link
Member Author

Thx @stuartnelson3! Indeed I've spotted the pending state but since the info comes from the mesh library and @brancz said that the lib might be replaced eventually, I didn't investigate further.

@brancz
Copy link
Member

brancz commented Dec 22, 2017

Still worth an investigation I would say, replacing weaveworks/mesh is a big task, it will take a long time.

@simonpasquier simonpasquier mentioned this pull request Dec 22, 2017
Closed
@simonpasquier simonpasquier deleted the improve-mesh-status branch January 23, 2018 17:18
@simonpasquier simonpasquier mentioned this pull request Feb 8, 2018
Merged
hh pushed a commit to ii/alertmanager that referenced this pull request Nov 20, 2018
@discordianfish @SuperQ
Add link to prometheus-dcgm (prometheus#1164)
bcec99e 
Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonpasquier @brancz @stuartnelson3