Add auth options for WebHook notifier #1149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds common authentication options to the WebHook notifier: - Bearer token - TLS client certificate - Basic authentication It also adds TLS options for CA certificate, server name and disabling validation of server-side certificates.
|
I'm still testing it on my side but in case someone has time for a review, go ahead. |
|
#516 is the one you mean. Security-related code should not be copied&pasted. |
This requires to pull github.com/prometheus/common/config in vendor.
ca8310f to
7d3288d
Compare
|
@brian-brazil PTAL when you have time. |
|
Closing it for now since it requires consensus across maintainers and another PR had already been opened. |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 19, 2018
* Change Dfly's CPU counting frequency, see: prometheus/node_exporter#1129 Signed-off-by: iori-yja <fivio.11235813@gmail.com> * Convert Dfly's CPU unit into second Signed-off-by: iori-yja <fivio.11235813@gmail.com> * Check BSD's mib which accounts for swap size; see prometheus#1127 Signed-off-by: iori-yja <fivo.11235813@gmail.com> * fix swap check code Signed-off-by: iori-yja <fivo.11235813@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds common authentication options to the WebHook notifier. Fixes #516.
TODO