Populate the silence form from location #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartnelson3
approved these changes
Dec 18, 2017
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 14, 2018
Add --web.disable-exporter-metrics flag
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 14, 2018
Signed-off-by: Ben Kochie <superq@gmail.com>
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Nov 19, 2018
Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1029
I decided to not synchronize the location when the form changes. This is done to be able to correctly reset the form and bring the original matchers back.
Ideally, we should support the same filter format as in alert list, but the silence form doesn't support negative filters (#1147), so that I had to omit them when populating the form from location.