Send the prom gen url as alert source #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation at https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2 payload.source: required string The unique location of the affected system, preferably a hostname or FQDN. Sending the generatorURL isn't technically the affected system, but an event sent to PD can encompass multiple alerts. The generatorURL seems like the correct way to help users debug this.
|
looking for opinions: @brancz @grobie @brian-brazil @beorn7 |
|
I believe our current behaviour is correct. The generator URL isn't right here, as a notification can come from multiple Prometheus servers (and technically generator URLs are per-alert). Randomly picking one alert doesn't seem right to me. I think the sane default is a link to the alertmanager, and allowing templating if a user knows something about their system that lets them select a better option. Which is what we already have. |
|
|
|
👍 Watch the commit message. |
As a sane default we link to alertmanager, but leave templating available to the user if something suits their system better.
2dcd86f to
813acfb
Compare
|
Updated the commit message to make sense, will merge once tests are green |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Oct 19, 2018
* Update Linux cpufreq collector to use new procfs library functions. * Split thermal throttle collection to a separate function. * Add new required fixtures and repack ttar file. Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the documentation at
https://v2.developer.pagerduty.com/docs/send-an-event-events-api-v2
Sending the generatorURL isn't technically the
affected system, but an event sent to PD can
encompass multiple alerts. The generatorURL seems
like the correct way to help users debug this.
addresses #1116