Fix silences negative filtering #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartnelson3
approved these changes
Nov 12, 2017
|
fix the merge conflicts and it's good to go |
4ef712d to
8a1d5ee
Compare
|
@stuartnelson3 Done. I've rebased the master commits. Thanks. |
stuartnelson3
approved these changes
Nov 15, 2017
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Oct 4, 2018
Signed-off-by: Andrew Banchich <andrewbanchich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the alerting filtering logic to be consistent with prometheus #1060.
This PR makes the same change to the silence filtering, and extract the filtering logic which is equal no matter if an alert, or silence. This way is easier for a new change to be effective cross alertmanager, without having to change two different places.