New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pushover limits (title, message, url) #1055

Merged

stuartnelson3 merged 1 commit into prometheus:master from josedonizetti:fix_pushover_notifications

Oct 25, 2017

Contributor

josedonizetti commented Oct 24, 2017

Couple things fixed

title was added as a parameter before the truncation
title limit was wrong, it is 250 characters
message limit was wrong, it is 1024 characters
url has a limit of 512 and was not truncated

Limits can be checked at https://pushover.net/api#limits
I've created a pushover account to do an end to end test, and truncation worked perfectly.


          Fix pushover limits (title, message, url)

2214f75

josedonizetti mentioned this pull request

Add ellipsis to truncated messages #1047

Closed

stuartnelson3 approved these changes

View reviewed changes

stuartnelson3 merged commit 0a16b09 into prometheus:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet