Initialise notifications_total and notifications_failed_total #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering whether we should also include the receiver name in this metric, and generally whether we should be initializing the metrics for all available notification providers or just those configured. |
|
There could be too many receiver names, potentially hundreds to thousands. I see the use case for this as spotting when PagerDuty is down, not that an individual receiver is misconfigured.
All is simplest, and it may always be configured later on. |
|
Makes sense, lgtm 👍 |
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Jul 22, 2018
…theus#1011) fixes prometheus#567 Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #928
This works but perhaps we could add a utility method of some kind to avoid duplication?