Inconsistent use of baseUrl and apiUrl arguments

Both are Strings, so flipping the order between one invocation and another didn't raise any argument from the compiler. The baseUrl argument is actually unnecessary, and has been removed.
prometheus · Sep 29, 2017 · ac8d7eb · ac8d7eb
1 parent 837cf5c
commit ac8d7eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ui/app/src/Updates.elm b/ui/app/src/Updates.elm
@@ -57,7 +57,7 @@ update msg ({ basePath, apiUrl } as model) =
         NavigateToSilenceView silenceId ->
             let
                 ( silenceView, cmd ) =
-                    Views.SilenceView.Updates.update (InitSilenceView silenceId) model.silenceView apiUrl basePath
+                    Views.SilenceView.Updates.update (InitSilenceView silenceId) model.silenceView apiUrl
             in
                 ( { model | route = SilenceViewRoute silenceId, silenceView = silenceView }
                 , Cmd.map MsgForSilenceView cmd
@@ -116,7 +116,7 @@ update msg ({ basePath, apiUrl } as model) =
         MsgForSilenceView msg ->
             let
                 ( silenceView, cmd ) =
-                    Views.SilenceView.Updates.update msg model.silenceView basePath apiUrl
+                    Views.SilenceView.Updates.update msg model.silenceView apiUrl
             in
                 ( { model | silenceView = silenceView }, Cmd.map MsgForSilenceView cmd )
 

diff --git a/ui/app/src/Views/SilenceView/Updates.elm b/ui/app/src/Views/SilenceView/Updates.elm
@@ -9,8 +9,8 @@ import Utils.Types exposing (ApiData(..))
 import Views.SilenceView.Types exposing (Model, SilenceViewMsg(..))
 
 
-update : SilenceViewMsg -> Model -> String -> String -> ( Model, Cmd SilenceViewMsg )
-update msg model apiUrl basePath =
+update : SilenceViewMsg -> Model -> String -> ( Model, Cmd SilenceViewMsg )
+update msg model apiUrl =
     case msg of
         FetchSilence id ->
             ( model, getSilence apiUrl id SilenceFetched )