-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return no error when deleting expired silence (#2817)
* Changed Silences.expire(id) to not return error for already expired silence Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Added comment explaining idempotency change for Silences.expire() Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Fixed typo in comment Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Fixed another typo in comment Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Promoted comment to function-level Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Added API v2 test for DeleteSilence, PostSilence Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Fixed lint errors Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com> * Trigger build Signed-off-by: Soon-Ping Phang <soonping@amazon.com>
- Loading branch information
1 parent
4030e36
commit a2d18c9
Showing
3 changed files
with
187 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters