[FEAT] Prometheus Adapter reload #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2023 09:29
Signed-off-by: rita.canavarro <ritinhamcm@gmail.com>
Signed-off-by: rita.canavarro <ritinhamcm@gmail.com>
|
|
|
@philipgough this annotation will force the Deployment pods to recreate when the md5 hash of the configMap changes. It is the strategy I use nowadays and what I also understood from this comment: #302 (comment). However, I might have misunderstood so could you please elaborate? |
|
@ritaCanavarro no sorry I misunderstood so my bad. That makes sense now. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a reload mechanism in Prometheus Adapter deployment every time its ConfigMap changes, as suggested in this issue #302.
Type of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Adds a reload mechanism in Prometheus Adapter deployment based on ConfigMap changes.