This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Use the right sized byte array for large indexes #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fileutil/mmap_windows.go
Outdated
| return (*[1 << 32]byte)(unsafe.Pointer(addr))[:sz], nil | ||
| } | ||
|
|
||
| if sz <= 1<<34 { |
There was a problem hiding this comment.
Why not always use this?
There was a problem hiding this comment.
You are allocating 16G everytime? Whether or not we are using it.
There was a problem hiding this comment.
Are you sure that's an allocation?
12a45e6 to
89b0e10
Compare
bwplotka
reviewed
Mar 14, 2018
| @@ -35,7 +35,7 @@ func mmap(f *os.File, sz int) ([]byte, error) { | |||
| return nil, os.NewSyscallError("CloseHandle", err) | |||
| } | |||
|
|
|||
| return (*[1 << 30]byte)(unsafe.Pointer(addr))[:sz], nil | |||
There was a problem hiding this comment.
sz is just size? Can we name it like that? (maybe just for master)
There was a problem hiding this comment.
Also I have stupid question. I have never used mmap before, but... why don't we cast to just [sz]byte here?
There was a problem hiding this comment.
I was thinking the same thing and tried it but casting to an array requires a constant for the array size as this is evaluated at compile time
- return (*[sz]byte)(unsafe.Pointer(addr))[:sz], nil = non-constant array bound
89b0e10 to
220d269
Compare
Fixes: prometheus/prometheus#3957 Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>
220d269 to
fb65e3d
Compare
|
👍 tsdb needs another revendor then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: prometheus/prometheus#3957
Not happy with this, suggestions welcome. @Bplotka
This change is