Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PercentTimeinGC metric #999

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Conversation

trunov-ms
Copy link
Contributor

@trunov-ms trunov-ms commented Jun 3, 2022

Fix bug for counting value PercentTimeinGC

From program WEBMTest.exe in class Win32_PerfRawData_NETFramework_NETCLRMemory I was found counter type

[DisplayName("% Time in GC"): ToInstance, countertype(537003008): ToInstance, 
perfindex(2606): ToInstance, helpindex(2607): ToInstance, defaultscale(0): ToInstance, 
perfdetail(100): ToInstance] uint32 PercentTimeinGC

The mapping for countertype(537003008) is PERF_RAW_FRACTION.

For Cooking Type MSDN has formula (100 * CounterValue) / BaseValue
Article

@trunov-ms trunov-ms requested a review from a team as a code owner June 3, 2022 12:54
Signed-off-by: Max Trunov <trunov_ms@taximaxim.ru>
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for submitting this and a big apology for not reviewing sooner! I must have accidentally hit "read" on the notification for this pull request and subsequently missed it.

I've left a couple minor comments, let me know if any info is needed.

Signed-off-by: Max Trunov <trunov_ms@taximaxim.ru>
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those amendments. The file needs to be formatted with gofmt in order to pass CI.
Once that's done we can merge the changes.

Signed-off-by: Max Trunov <trunov_ms@taximaxim.ru>
@breed808 breed808 merged commit f8abca5 into prometheus-community:master Sep 10, 2022
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants