Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] Remove field volumeBindingMode #5308

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

zeritti
Copy link
Contributor

@zeritti zeritti commented Feb 10, 2025

What this PR does / why we need it

Field server.persistentVolume.volumeBindingMode is not applicable to a persistent volume. This PR removes it from the templates. Furthermore, ci is to be excluded from the released artefact.

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
@zeritti zeritti marked this pull request as ready for review February 10, 2025 18:24
@zanhsieh zanhsieh merged commit 4789777 into prometheus-community:main Feb 14, 2025
5 checks passed
@zeritti zeritti deleted the prometheus-volume-binding branch February 15, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus] PVC has no attribute VolumeBindingMode
2 participants