Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding own elements to gittattributes #866

Closed
Hi-Fi opened this issue Jun 8, 2021 · 0 comments · Fixed by #875
Closed

Allow adding own elements to gittattributes #866

Hi-Fi opened this issue Jun 8, 2021 · 0 comments · Fixed by #875

Comments

@Hi-Fi
Copy link
Contributor

Hi-Fi commented Jun 8, 2021

Currently .gitattributes file is autogenerated without possibility to inject own values to it (like with e.g. .gitignore).

It would be good to have API to inject values to .gitattributes to handle situation between Linux and Windows (like in here users when hashes from files are used in some ID generation. This would work as a workaround for aws/aws-cdk#14555.
eladb pushed a commit that referenced this issue Jun 10, 2021
feat(project): gitattributes
d34fb07 
Allow interaction with .gitattributes through `project.gitattributes` - resolves #866

Misc: reduce some coupling between components and the GitHub component in `Project` as a prep to abstract away some of the GitHub features (such as CI/CD).

BREAKING CHANGE: `project.github.annotateGenerated()` is now `project.annotateGenerated`
* **auto-merge:** AutoMerge now takes `mergify` as a required property (instead of implicitly through `project.github?.mergify`).
@eladb eladb mentioned this issue Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(project): gitattributes projen/projen
1 participant
@Hi-Fi